From 98841eb694fa3cd575fde60e562586cf33415c5b Mon Sep 17 00:00:00 2001 From: Dave Reisner Date: Sat, 10 May 2014 09:31:26 -0400 Subject: [PATCH] common: remove unreachable statement We run from a non-interactive shell, so the exec which is inevitably called will replace the current process and 'die' will never run under any circumstances. This also fixes a bug with the su fallback which would cause multiple arguments to be concatenated without any whitespace between them. --- lib/common.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/common.sh b/lib/common.sh index 104850b..f6aea93 100644 --- a/lib/common.sh +++ b/lib/common.sh @@ -238,7 +238,6 @@ check_root() { if type -P sudo >/dev/null; then exec sudo -- "$@" else - exec su root -c "$(printf '%q' "$@")" + exec su root -c "$(printf ' %q' "$@")" fi - die 'This script must be run as root.' } -- GitLab