Commit d3ec367c authored by Anael Beutot's avatar Anael Beutot Committed by Antoine Millet
Browse files

Prevent clients from sending anything other than strings as tag values

parent 0870575c

cloudcontrol/common/client/tags.py

+5 −4
Original line number Diff line number Diff line
@@ -532,7 +532,7 @@ class RootTagDB(TagDB): 
        logger.debug('RPC register tag %s', tag.name)

        ttl = None if tag.ttl == -1 else tag.ttl

        self.rpc_call(tag.name, self.rpc_tag_register_cb, 'tags_register',

                      tag.name, ttl, tag.value)

                      tag.name, ttl, unicode(tag.value))



    def rpc_unregister_tag(self, tag_name):

        logger.debug('RPC unregister tag %s', tag_name)
@@ -544,16 +544,17 @@ class RootTagDB(TagDB): 
        logger.debug('RPC update tag %s(%s)', tag.name, sub_id)

        if sub_id == '__main__':

            self.rpc_call(sub_id + tag.name, self.rpc_update_tag_cb,

                          'tags_update', tag.name, tag.value)

                          'tags_update', tag.name, unicode(tag.value))

        else:

            self.rpc_call(sub_id + tag.name, self.rpc_update_tag_cb,

                          'sub_tags_update', sub_id, tag.name, tag.value)

                          'sub_tags_update', sub_id, tag.name, unicode(tag.value))



    def rpc_register_sub_tag(self, sub_id, tag):

        logger.debug('RPC register tag %s(%s)', tag.name, sub_id)

        ttl = None if tag.ttl == -1 else tag.ttl

        self.rpc_call(tag.name, self.rpc_sub_tag_register_cb,

                      'sub_tags_register', sub_id, tag.name, ttl, tag.value)

                      'sub_tags_register', sub_id, tag.name, ttl,

                      unicode(tag.value))



    def rpc_unregister_sub_tag(self, sub_id, tag_name):

        logger.debug('RPC unregister tag %s(%s)', tag_name, sub_id)