Commit 9a29f624 authored by Eric Bélanger's avatar Eric Bélanger Committed by Pierre Schmitz
Browse files

checkpkg: Clean up soname check output 



A missing quote in a grep command was giving out false matches.

By moving the objdump command in the same echo statement as the
filename, we ensure that every library name are displayed on a line of
their own in case they don't have a SONAME defined in their
headers. That is the case for some plugin libraries.

Signed-off-by: default avatarEric Bélanger <snowmaniscool@gmail.com>
Signed-off-by: default avatarPierre Schmitz <pierre@archlinux.de>
parent 3040951c

checkpkg

+2 −3
Original line number Diff line number Diff line
@@ -87,9 +87,8 @@ for _pkgname in ${pkgname[@]}; do 
		mkdir -p pkg

		cd pkg

		bsdtar xf ../"$pkgfile" > /dev/null

		for i in $(diff ../filelist-$_pkgname-old ../filelist-$_pkgname | grep \> | grep \.so | awk '{print $2}'); do

			echo -n "${i}: "

			objdump -p $i | grep SONAME

		for i in $(diff ../filelist-$_pkgname-old ../filelist-$_pkgname | grep \> | grep '\.so' | awk '{print $2}'); do

			echo "${i}: " "$(objdump -p $i | grep SONAME)"

		done

		cd ..

	else