Commit fdd079f3 authored by Joel Teichroeb's avatar Joel Teichroeb Committed by Pierre Schmitz
Browse files

Remove broken unknown arguments check and fix usage 



If getopts comes across an unknown argument, $arg it set to '?' and
$OPTARG is unset. Therefore the getopts line detecting unknown arguments
doesn't work. Arguments to pass to makepkg are already handled by
passing all the aguments after the end-of-options marker (--), but this
wasn't documented in the usage text.

Signed-off-by: default avatarPierre Schmitz <pierre@archlinux.de>
parent 9f7ba3d4

makechrootpkg.in

+2 −3
Original line number Diff line number Diff line
@@ -35,8 +35,8 @@ src_owner=${SUDO_USER:-$USER} 
usage() {

	echo "Usage: ${0##*/} [options] -r <chrootdir> [--] [makepkg args]"

	echo ' Run this script in a PKGBUILD dir to build a package inside a'

	echo ' clean chroot. All unrecognized arguments passed to this script'

	echo ' will be passed to makepkg.'

	echo ' clean chroot. Arguments passed to this script after the'

	echo ' end-of-options marker (--) will be passed to makepkg.'

	echo ''

	echo ' The chroot dir consists of the following directories:'

	echo ' <chrootdir>/{root, copy} but only "root" is required'
@@ -78,7 +78,6 @@ while getopts 'hcur:I:l:nTD:d:' arg; do 
		l) copy="$OPTARG" ;;

		n) run_namcap=true; makepkg_args="$makepkg_args -i" ;;

		T) temp_chroot=true; copy+="-$$" ;;

		*) makepkg_args="$makepkg_args -$arg $OPTARG" ;;

	esac

done